Skip to content

Let :gen_tcp pick a random port for us - #22

Closed
krisalyssa wants to merge 1 commit into
kcelixir:masterfrom
krisalyssa:random-test-port
Closed

krisalyssa wants to merge 1 commit into
kcelixir:masterfrom
krisalyssa:random-test-port

Conversation

@krisalyssa

Copy link
Copy Markdown

No description provided.

@jeffutter jeffutter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer nectar to default to a port (for when you mix nectar.server and have tests pass in 0 for a random port.

Comment thread lib/nectar.ex

def start(_type, args) do
port = Keyword.get(args, :port, 8080)
requested_port = Keyword.get(args, :port, 0)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for tests, but it would be nice to default a port for when you mix nectar.server similar to how phoenix defaults to 4000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants